Code review is an engineering process that has benefited greatly from a move toward asynchronous communication. Long ago, engineering teams would sit in a room with code on a projector to review changes together. 😱 For many teams this led to batching code reviews or even skipping them altogether. 😱😱
Today, most engineering teams use incredible tools like GitHub or GitLab to review changes through Pull Requests (PRs). The greatest advantage of PRs is that the review can happen when it’s convenient for the reviewer: asynchronously. Asynchronous communication isn’t all sunshine and unicorns, though. Notably, it lacks the ability to course-correct when context is misunderstood.
When you’re in a synchronous conversation with someone, it doesn’t take much time for them to let you know you’ve forgotten to include context. Their brow furrows. They look confused. You notice this and quickly add the missing context to keep the conversation moving forward. It takes a lot longer to identify missing context when communicating asynchronously. The non-verbal cues are missing.
Worse, lack of context when reviewing code asynchronously has a reverb effect. I create my PR when it’s convenient for me, you ask a clarifying question when it’s convenient for you, I respond when it’s convenient for me, etc. Suddenly my PR has been open for three days and we haven’t yet made it to a common understanding of why I’ve made these changes.
It’s extremely important to include all available context when drafting a PR. It saves incredible amounts of time by cutting out slow round-trip conversations to clarify.
I’m personally proud of and impressed by the job we do at Artsy in including context in our PRs. We start early, by giving our engineers some reading about how we work with PRs during their onboarding.
But beyond that our engineers lead by example. This article presents a handful of examples from Artsy repositories demonstrating how you can add context to your PRs to avoid unnecessary clarifying conversation.
Explain Your Reasoning
You’ve been thinking a lot about the problem you’re solving - probably significantly more than your reviewers. You’ll save everyone time by describing the problem and sharing how you’re thinking about it.
Define the problem and solution
As you are writing up the problem and solution, you might find that you’ve missed on the scope of your PR. Are there many problems this PR is solving? Maybe this should be broken into smaller PRs. Is it hard to describe the problem because it requires multiple other PRs? Maybe those should be consolidated into one cohesive set of changes.
Explain interesting lines of code
The reviewers aren’t the only ones who can comment on lines of code. Give them some additional information about why a particular line was written, as David does in this PR. Maybe you want feedback focused on that line or maybe the line has side-effects and implications that aren’t obvious.
Give a guided tour of the changes
Devon takes the idea of adding context to individual lines to the next level in this PR. He takes advantage of markdown to give us a virtual tour of the changes, at each stop providing helpful information and a link to the next change. It’s like he’s sitting next to you!
Show Your Work
If your PR contains work that is beyond trivial, show your reviewers how you thought about the problem. Demonstrate the effects of the changes. Give them confidence that you’ve worked through this problem thoroughly, and you’ve brought receipts.
Make small, self-contained commits
A good PR starts with good commits. Good commits are small, self-contained, and leave the codebase always in a working state. With good commits, reviewers can see exactly how you worked through the problem you were solving. Here’s a PR from Jon that demonstrates the use of small, self-contained commits to describe his approach to refactoring code before fixing a bug.
Demonstrate the results
Pictures are a worth a thousand words. Animated gifs are worth a thousand pictures (uhhhh, in file size too 😬). An animated gif showing the outcome of your PR gives reviewers a demo, and confidence that you’ve verified your changes.
Document the unseen
Sometimes a PR’s changes have effects outside of the UI. There are still ways to give reviewers proof that the changes have the desired effects.
Share your progress
One mistake many engineers make with non-trivial pull requests is to wait to open them until they’re “done”. If
there are changes you’d like to get people’s eyes on quickly, open a WIP PR before the work is done: mark it as a
draft in GitHub, or put
WIP in the title. Extra work up front avoids rework by starting early discussions about
Is this PR part of a larger scope of work? Is there followup work that will need to be done after it’s merged? Are there PRs in other systems that need to merge in a specific sequence? Any migration details or timing that should be known before merging? Call these details out to avoid another round-trip conversation.
Pull requests should not be one-sided - they aren’t just about collecting feedback from the reviewer. They’re also an opportunity to spread knowledge from the author.
Share your learnings
Maybe you learned some things about the system you’re working with, or you learned a new feature of the language. Share this new information with your team. Roop shares some findings about disabled tests in this PR.
Share development tips
Did you learn a new technique while building this feature? Share it with your team!
When your team embraces the pull request process, you reap rewards that extend far beyond the lines of code. Providing context up-front shortens the feedback loop and surfaces important discussions sooner, allowing you to ship changes more quickly. Sharing knowledge in PRs grows individuals and spreads expertise across your team. Every PR becomes an artifact for retracing history. You can look back and see not only which decisions were made, but why they were made.
If you’d like to know more about how we work with pull requests at Artsy, take a look at our “Engineer workflow” playbook, or poke around our GitHub repositories. Check out the PR that created this article. And if you’ve got examples of great PRs to share with the rest of us, leave a comment!